Re: [PATCH] ceph/002: fix test expected output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 20, 2022 at 10:47:09AM +0100, Luís Henriques wrote:
> Commit daa0c0146c7d ("fstests: replace hexdump with od command") broke
> ceph/002 by adding an extra '0' in the offset column.  Fix it.
> 
> Signed-off-by: Luís Henriques <lhenriques@xxxxxxx>
> ---

Oh, that's my bad, I changed that in daa0c014 ("fstests: replace hexdump
with od command"), but write an extra '0' for ceph/002.out [1]. And due to
I don't test cephfs, so missed this failure. Thanks for fixing it!

Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

[1]
...
diff --git a/tests/ceph/002.out b/tests/ceph/002.out
index 6f067250..f7f1c0ba 100644
--- a/tests/ceph/002.out
+++ b/tests/ceph/002.out
@@ -1,8 +1,8 @@
 QA output created by 002
-0000000 6161 6161 6161 6161 6161 6161 6161 6161
+000000 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61  >aaaaaaaaaaaaaaaa<
 *
-0400000 6262 6262 6262 6262 6262 6262 6262 6262
+400000 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62  >bbbbbbbbbbbbbbbb<
 *
-0800000 6363 6363 6363 6363 6363 6363 6363 6363
+800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
 *
-0c00000
+c000000
...

>  tests/ceph/002.out | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/ceph/002.out b/tests/ceph/002.out
> index f7f1c0ba8487..4f766c257a9c 100644
> --- a/tests/ceph/002.out
> +++ b/tests/ceph/002.out
> @@ -5,4 +5,4 @@ QA output created by 002
>  *
>  800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
>  *
> -c000000
> +c00000
> 




[Index of Archives]     [CEPH Users]     [Ceph Large]     [Ceph Dev]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux