Re: [PATCH v5 4/4] ceph: Remove S_ISGID clear code in ceph_finish_async_create

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 21, 2022 at 03:54:18PM +0800, Yang Xu wrote:
> Since vfs has stripped S_ISGID in the previous patch, the calltrace
> as below:
> 
> vfs:	lookup_open
> 	...
> 	  if (open_flag & O_CREAT) {
>                 if (open_flag & O_EXCL)
>                         open_flag &= ~O_TRUNC;
>                 mode = prepare_mode(mnt_userns, dir->d_inode, mode);
> 	...
> 	   dir_inode->i_op->atomic_open
> 
> ceph:	ceph_atomic_open
> 	...
> 	      if (flags & O_CREAT)
>             		ceph_finish_async_create
> 
> We have stripped sgid in prepare_mode, so remove this useless clear
> code directly.

I'd replace this with:

"Previous patches moved sgid stripping exclusively into the vfs. So
manual sgid stripping by the filesystem isn't needed anymore."

> 
> Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxx>
> ---

Reviewed-by: Christian Brauner (Microsoft) <brauner@xxxxxxxxxx>



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Ceph Dev]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux