On Wed, Mar 16, 2022 at 9:21 AM <xiubli@xxxxxxxxxx> wrote:
>
> From: Xiubo Li <xiubli@xxxxxxxxxx>
>
> Since the base64_encrypted file name shouldn't exceed the NAME_SIZE,
> no need to allocate a buffer from the stack that long.
>
> Signed-off-by: Xiubo Li <xiubli@xxxxxxxxxx>
> ---
>
> Jeff, you can just squash this into the previous commit.
>
>
> fs/ceph/mds_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index c51b07ec72cf..cd0c780a6f84 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -2579,7 +2579,7 @@ char *ceph_mdsc_build_path(struct dentry *dentry, int *plen, u64 *pbase, int for
> parent = dget_parent(cur);
> } else {
> int len, ret;
> - char buf[FSCRYPT_BASE64URL_CHARS(NAME_MAX)];
> + char buf[NAME_MAX];
>
> /*
> * Proactively copy name into buf, in case we need to present
> --
> 2.27.0
>
Makes sense.
Acked-by: Venky Shankar <vshankar@xxxxxxxxxx>
--
Cheers,
Venky
