On 2/15/22 5:16 PM, Venky Shankar wrote:
Right now, cumulative read/write/metadata latencies are tracked and are periodically forwarded to the MDS. These meterics are not particularly useful. A much more useful metric is the average latency and standard deviation (stdev) which is what this series of patches aims to do. The userspace (libcephfs+tool) changes are here:: https://github.com/ceph/ceph/pull/41397 Note that the cumulative latencies are still forwarded to the MDS but the tool (cephfs-top) ignores it altogether. Latency standard deviation is calculated in `cephfs-top` tool. Venky Shankar (3): ceph: track average r/w/m latency ceph: include average/stdev r/w/m latency in mds metrics ceph: use tracked average r/w/m latencies to display metrics in debugfs fs/ceph/debugfs.c | 2 +- fs/ceph/metric.c | 44 +++++++++++++++++++++++---------------- fs/ceph/metric.h | 52 +++++++++++++++++++++++++++++++++-------------- 3 files changed, 65 insertions(+), 33 deletions(-)
This series looks good to me. Reviewed-by: Xiubo Li <xiubli@xxxxxxxxxx>