From: Xiubo Li <xiubli@xxxxxxxxxx> This patch series is based on the fscrypt_size_handling branch in https://github.com/lxbsz/linux.git, which is based Jeff's ceph-fscrypt-content-experimental branch in https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git, has reverted one useless commit and added some upstream commits. I will keep this patch set as simple as possible to review since this is still one framework code. It works and still in developing and need some feedbacks and suggestions for two corner cases below. ==== This approach is based on the discussion from V1, which will pass the encrypted last block contents to MDS along with the truncate request. This will send the encrypted last block contents to MDS along with the truncate request when truncating to a smaller size and at the same time new size does not align to BLOCK SIZE. The MDS side patch is raised in PR https://github.com/ceph/ceph/pull/43588, which is also based Jeff's previous great work in PR https://github.com/ceph/ceph/pull/41284. The MDS will use the filer.write_trunc(), which could update and truncate the file in one shot, instead of filer.truncate(). I have removed the inline data related code since we are remove this feature, more detail please see: https://tracker.ceph.com/issues/52916 Note: There still has two CORNER cases we need to deal with: 1), If a truncate request with the last block is sent to the MDS and just before the MDS has acquired the xlock for FILE lock, if another client has updated that last block content, we will over write the last block with old data. For this case we could send the old encrypted last block data along with the truncate request and in MDS side read it and then do compare just before updating it, if the comparasion fails, then fail the truncate and let the kclient retry it. 2), If another client has buffered the last block, we should flush it first. I am still thinking how to do this ? Any idea is welcome. Thanks. Xiubo Li (4): ceph: add __ceph_get_caps helper support ceph: add __ceph_sync_read helper support ceph: return the real size readed when hit EOF ceph: add truncate size handling support for fscrypt fs/ceph/caps.c | 28 ++++--- fs/ceph/file.c | 41 ++++++---- fs/ceph/inode.c | 210 ++++++++++++++++++++++++++++++++++++++++++------ fs/ceph/super.h | 4 + 4 files changed, 234 insertions(+), 49 deletions(-) -- 2.27.0
