On Wed, Aug 25, 2021 at 1:51 AM Venky Shankar <vshankar@xxxxxxxxxx> wrote:
>
> Signed-off-by: Venky Shankar <vshankar@xxxxxxxxxx>
> ---
> fs/ceph/debugfs.c | 36 ++++++++++++++++++++++++++++++++++++
> fs/ceph/super.c | 3 +++
> fs/ceph/super.h | 2 ++
> 3 files changed, 41 insertions(+)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 66989c880adb..f9ff70704423 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -22,6 +22,14 @@
> #include "mds_client.h"
> #include "metric.h"
>
> +#define CLIENT_FEATURES_DIR_NAME "client_features"
> +#define MOUNT_DEVICE_V1_SUPPORT_FILE_NAME "v1_mount_syntax"
> +#define MOUNT_DEVICE_V2_SUPPORT_FILE_NAME "v2_mount_syntax"
> +
> +static struct dentry *ceph_client_features_dir;
> +static struct dentry *ceph_mount_device_v1_support;
> +static struct dentry *ceph_mount_device_v2_support;
> +
> static int mdsmap_show(struct seq_file *s, void *p)
> {
> int i;
> @@ -416,6 +424,26 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
> &status_fops);
> }
>
> +void ceph_fs_debugfs_client_features_init(void)
> +{
> + ceph_client_features_dir = debugfs_create_dir(CLIENT_FEATURES_DIR_NAME,
> + ceph_debugfs_dir);
> + ceph_mount_device_v1_support = debugfs_create_file(MOUNT_DEVICE_V1_SUPPORT_FILE_NAME,
> + 0400,
> + ceph_client_features_dir,
> + NULL, NULL);
> + ceph_mount_device_v2_support = debugfs_create_file(MOUNT_DEVICE_V2_SUPPORT_FILE_NAME,
> + 0400,
> + ceph_client_features_dir,
> + NULL, NULL);
> +}
Makes sense to me. I can see having separate files for each syntax
type is expedient. If Jeff is cool with this then so am I.
--
Patrick Donnelly, Ph.D.
He / Him / His
Principal Software Engineer
Red Hat Sunnyvale, CA
GPG: 19F28A586F808C2402351B93C3301A3E258DD79D
