Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > means you can't get there unless PageUptodate() is true by that point. > > Isn't the point of an assertion to check that this is true? The assertion was meant to check that that it was true given that the page was set uptodate somewhere else before this function was even called. With this patch, however, it's now set in this function if it wasn't already right at the top - so the assertion should now be redundant. I can put it back if you really insist. David