Re: [PATCH] netfs: fix test for whether we can skip read when writing beyond EOF

[David Howells <dhowells@xxxxxxxxxx>]

Jeff Layton <jlayton@xxxxxxxxxx> wrote:

> +	/* full page write */
> +	if (offset == 0 && len >= thp_size(page))
> +		goto zero_out;

Why not just return?

David Howells <dhowells@xxxxxxxxxx> wrote:

> Why not:
> 
> 	if (page_offset(page) >= i_size)

And if I switch to this, then:

	/* Zero-length file */
	if (i_size == 0)
		goto zero_out;

this is redundant.

David