On 2021/4/28 22:14, Jeff Layton wrote:
On Wed, 2021-04-28 at 14:08 +0800, xiubli@xxxxxxxxxx wrote:
From: Xiubo Li <xiubli@xxxxxxxxxx>
V3:
- update and rename __update_latency to __update_stdev.
V2:
- remove the unused parameters in metric.c
- a small clean up for the code.
For the read/write IO speeds, will leave them to be computed in
userspace,
where it can get a preciser result with float type.
Xiubo Li (2):
ceph: update and rename __update_latency helper to __update_stdev
ceph: add IO size metrics support
fs/ceph/addr.c | 14 +++++----
fs/ceph/debugfs.c | 37 +++++++++++++++++++++---
fs/ceph/file.c | 23 +++++++--------
fs/ceph/metric.c | 74 ++++++++++++++++++++++++++++++++---------------
fs/ceph/metric.h | 10 +++++--
5 files changed, 111 insertions(+), 47 deletions(-)
Thanks Xiubo,
This looks good. Merged into ceph-client/testing.
My only (minor) complaint is that the output of
/sys/kernel/debug/ceph/*/metrics is a bit ad-hoc and messy, especially
when there are multiple mounts. It might be good to clean that up in a
later patch, but I don't see it as a reason to block merging this.
BTW, each mounter will have its own "/sys/.../metrics" file, what do you
mean for multiple mounts here ? Is there any case will they be messed up
or something else ?
Thanks.
Cheers,
