On Mon, 2021-02-01 at 15:52 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./fs/ceph/debugfs.c:347:0-23: WARNING: congestion_kb_fops should be > defined with DEFINE_DEBUGFS_ATTRIBUTE. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > --- > fs/ceph/debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c > index 66989c8..617327e 100644 > --- a/fs/ceph/debugfs.c > +++ b/fs/ceph/debugfs.c > @@ -344,8 +344,8 @@ static int congestion_kb_get(void *data, u64 *val) > return 0; > } > > > -DEFINE_SIMPLE_ATTRIBUTE(congestion_kb_fops, congestion_kb_get, > - congestion_kb_set, "%llu\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(congestion_kb_fops, congestion_kb_get, > + congestion_kb_set, "%llu\n"); > > > > > void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc) Looks reasonable. Merged into ceph-client/testing branch. Thanks! -- Jeff Layton <jlayton@xxxxxxxxxx>
