On Thu, Dec 17, 2020 at 2:25 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Wed, 16 Dec 2020 21:02:39 +0800 Zheng Yongjun wrote: > > The parameter of kfree function is NULL, so kfree code is useless, delete it. > > > > Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx> > > To be clear the subject tags is misleading we're not taking this > into the networking tree, ceph folk please go ahead :) I still didn't get the original patch for some reason, but looking at https://lists.openwall.net/netdev/2020/12/16/163 the kfree is not useless. If ceph_decode_need() fails, the array needs to be freed, so we are not taking this into the ceph tree either ;) Thanks, Ilya
