On Wed, Dec 16, 2020 at 4:31 PM Jeff Layton <jlayton@xxxxxxxxxx> wrote: > > On Mon, 2020-12-14 at 14:43 +0100, Ilya Dryomov wrote: > > Hello, > > > > I've pushed wip-msgr2 and opened a dummy PR in ceph-client: > > > > https://github.com/ceph/ceph-client/pull/22 > > > > This set has been through a over a dozen krbd test suite runs with no > > issues other than those with the test suite itself. The diffstat is > > rather big, so I didn't want to spam the list. If someone wants it > > posted, let me know. Any comments are welcome! > > > > drivers/block/rbd.c | 8 +- > > fs/ceph/mds_client.c | 106 +- > > fs/ceph/mdsmap.c | 21 +- > > include/linux/ceph/auth.h | 68 +- > > include/linux/ceph/ceph_features.h | 11 +- > > include/linux/ceph/ceph_fs.h | 11 + > > include/linux/ceph/decode.h | 8 + > > include/linux/ceph/libceph.h | 10 +- > > include/linux/ceph/mdsmap.h | 2 +- > > include/linux/ceph/messenger.h | 285 ++- > > include/linux/ceph/msgr.h | 57 +- > > include/linux/ceph/osdmap.h | 4 +- > > net/ceph/Kconfig | 3 + > > net/ceph/Makefile | 3 +- > > net/ceph/auth.c | 408 ++++- > > net/ceph/auth_none.c | 5 +- > > net/ceph/auth_x.c | 298 +++- > > net/ceph/auth_x_protocol.h | 3 +- > > net/ceph/ceph_common.c | 63 + > > net/ceph/ceph_strings.c | 28 + > > net/ceph/crypto.h | 3 + > > net/ceph/decode.c | 101 ++ > > net/ceph/messenger.c | 2252 +++++------------------ > > net/ceph/messenger_v1.c | 1506 ++++++++++++++++ > > net/ceph/messenger_v2.c | 3443 ++++++++++++++++++++++++++++++++ > > net/ceph/mon_client.c | 320 +++- > > net/ceph/osd_client.c | 111 +- > > net/ceph/osdmap.c | 45 +- > > 28 files changed, 7027 insertions(+), 2156 deletions(-) > > create mode 100644 net/ceph/messenger_v1.c > > create mode 100644 net/ceph/messenger_v2.c > > > > Thanks, > > > > Ilya > > FWIW, I see these warnings when building with this series with W=1: > > ./include/linux/ceph/msgr.h:37:24: warning: ‘CEPH_MSGR2_FEATUREMASK_REVISION_1’ defined but not used [-Wunused-const-variable=] > 37 | static const uint64_t CEPH_MSGR2_FEATUREMASK_##name = \ > | ^~~~~~~~~~~~~~~~~~~~~~~ > ./include/linux/ceph/msgr.h:43:1: note: in expansion of macro ‘DEFINE_MSGR2_FEATURE’ > 43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1) // msgr2.1 > | ^~~~~~~~~~~~~~~~~~~~ > ./include/linux/ceph/msgr.h:36:24: warning: ‘CEPH_MSGR2_FEATURE_REVISION_1’ defined but not used [-Wunused-const-variable=] > 36 | static const uint64_t CEPH_MSGR2_FEATURE_##name = (1ULL << bit); \ > | ^~~~~~~~~~~~~~~~~~~ > ./include/linux/ceph/msgr.h:43:1: note: in expansion of macro ‘DEFINE_MSGR2_FEATURE’ > 43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1) // msgr2.1 > | ^~~~~~~~~~~~~~~~~~~~ > > It's probably easy to fix, but I haven't looked in detail yet. Yeah, consider it fixed. (I probably need to start building with W=1, considering that people seem to have started caring about it these days...) Thanks, Ilya
