On Wed, Oct 07, 2020 at 06:52:09PM +0100, Luis Henriques wrote: > This is my second attempt to have an initial set of ceph-specific tests > merged into fstests. In this patchset I'm pushing a different set of > tests, focusing on the copy_file_range testing, although I *do* plan to > get back to the quota tests soon. I have no knowledge about cephfs, I don't have a cephfs test env either, so I can only comment from fstests' perspect of view. It'd be great if other ceph folks could help review this patchset as well. >From fstests perspect of view, this patchset looks fine to me, just some minor comments go to individual patch. > > This syscall has a few peculiarities in ceph as it is able to use remote > object copies without the need to download/upload data from the OSDs. > However, in order to take advantage of this remote copy, the copy ranges > and sizes need to include at least one object. Thus, all the currently > existing generic tests won't actually take advantage of this feature. > > Let me know any comments/concerns about this patchset. Also note that > currently, in order to enable copy_file_range in cephfs, the additional > 'copyfrom' mount parameter is required. (Hopefully this additional param I assume '_require_xfs_io_command "copy_range"' will _notrun the test if there's no 'copyfrom' mount option provided, and test won't fail. > may be dropped in the future.) > > Luis Henriques (3): > ceph: add copy_file_range (remote copy operation) testing > ceph: test combination of copy_file_range with truncate > ceph: test copy_file_range with infile = outfile > > tests/ceph/001 | 233 +++++++++++++++++++++++++++++++++++++++++++++ > tests/ceph/001.out | 129 +++++++++++++++++++++++++ > tests/ceph/002 | 74 ++++++++++++++ > tests/ceph/002.out | 8 ++ > tests/ceph/003 | 118 +++++++++++++++++++++++ > tests/ceph/003.out | 11 +++ > tests/ceph/group | 3 + > 7 files changed, 576 insertions(+) > create mode 100644 tests/ceph/001 New test should have file mode 755, i.e. with x bit set. The 'new' script should have done this for you. Thanks, Eryu > create mode 100644 tests/ceph/001.out > create mode 100644 tests/ceph/002 > create mode 100644 tests/ceph/002.out > create mode 100644 tests/ceph/003 > create mode 100644 tests/ceph/003.out > create mode 100644 tests/ceph/group
