On Tue, 2020-08-18 at 13:10 -0700, Patrick Donnelly wrote: > On Tue, Aug 18, 2020 at 1:05 PM Jeff Layton <jlayton@xxxxxxxxxx> wrote: > > Bear in mind that if the same file has been opened several times, then > > you'll get an increment for each. > > Having an open file count (even for the same inode) and a count of > inodes opened sounds useful to me. The latter would require some kind > of refcounting for each inode? Maybe that's too expensive though. > It might be useful. It really depends on what you want to do with this info. The MDS is generally interested in inodes and their caps, and it usually knows how many opens we have, except in the case where we have sufficient caps and can make the attempt w/o having to talk to it. Is knowing an official number of actual open file descriptions helpful? Why? > > Would it potentially be more useful to report the number of inodes that > > have open file descriptions associated with them? It's hard for me to > > know as I'm not clear on the intended use-case for this. > > Use-case is more information available via `fs top`. > Which is, again, vague. What do you expect to do with this info? Why is it useful? Articulating that up front will help us determine whether we're measuring what we need to measure. -- Jeff Layton <jlayton@xxxxxxxxxx>
