Hi Joe, I love your patch! Yet something to improve: [auto build test ERROR on ceph-client/for-linus] [also build test ERROR on v5.9-rc1 next-20200814] [cannot apply to sage-ceph/for-linus] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Joe-Perches/ceph-Neaten-debugging/20200817-060623 base: https://github.com/ceph/ceph-client.git for-linus config: arc-randconfig-r014-20200817 (attached as .config) compiler: arc-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/block/rbd.c: In function 'rbd_client_create': >> drivers/block/rbd.c:761:2: error: implicit declaration of function 'dout'; did you mean 'dput'? [-Werror=implicit-function-declaration] 761 | dout("%s:\n", __func__); | ^~~~ | dput cc1: some warnings being treated as errors # https://github.com/0day-ci/linux/commit/ab0413062c34a692c0480a3237a04534f823e02d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Joe-Perches/ceph-Neaten-debugging/20200817-060623 git checkout ab0413062c34a692c0480a3237a04534f823e02d vim +761 drivers/block/rbd.c 602adf400201636 Yehuda Sadeh 2010-08-12 751 602adf400201636 Yehuda Sadeh 2010-08-12 752 /* 7262cfca430a1a0 Alex Elder 2013-05-16 753 * Initialize an rbd client instance. Success or not, this function cfbf6377b696d88 Alex Elder 2013-05-31 754 * consumes ceph_opts. Caller holds client_mutex. 602adf400201636 Yehuda Sadeh 2010-08-12 755 */ f8c3892911145db Alex Elder 2012-08-10 756 static struct rbd_client *rbd_client_create(struct ceph_options *ceph_opts) 602adf400201636 Yehuda Sadeh 2010-08-12 757 { 602adf400201636 Yehuda Sadeh 2010-08-12 758 struct rbd_client *rbdc; 602adf400201636 Yehuda Sadeh 2010-08-12 759 int ret = -ENOMEM; 602adf400201636 Yehuda Sadeh 2010-08-12 760 37206ee5bede14d Alex Elder 2013-02-20 @761 dout("%s:\n", __func__); 602adf400201636 Yehuda Sadeh 2010-08-12 762 rbdc = kmalloc(sizeof(struct rbd_client), GFP_KERNEL); 602adf400201636 Yehuda Sadeh 2010-08-12 763 if (!rbdc) 602adf400201636 Yehuda Sadeh 2010-08-12 764 goto out_opt; 602adf400201636 Yehuda Sadeh 2010-08-12 765 602adf400201636 Yehuda Sadeh 2010-08-12 766 kref_init(&rbdc->kref); 602adf400201636 Yehuda Sadeh 2010-08-12 767 INIT_LIST_HEAD(&rbdc->node); 602adf400201636 Yehuda Sadeh 2010-08-12 768 74da4a0f574d11e Ilya Dryomov 2017-03-03 769 rbdc->client = ceph_create_client(ceph_opts, rbdc); 602adf400201636 Yehuda Sadeh 2010-08-12 770 if (IS_ERR(rbdc->client)) 08f75463c15e26e Alex Elder 2013-05-29 771 goto out_rbdc; 43ae47011232c1e Alex Elder 2012-07-03 772 ceph_opts = NULL; /* Now rbdc->client is responsible for ceph_opts */ 602adf400201636 Yehuda Sadeh 2010-08-12 773 602adf400201636 Yehuda Sadeh 2010-08-12 774 ret = ceph_open_session(rbdc->client); 602adf400201636 Yehuda Sadeh 2010-08-12 775 if (ret < 0) 08f75463c15e26e Alex Elder 2013-05-29 776 goto out_client; 602adf400201636 Yehuda Sadeh 2010-08-12 777 432b858749631dc Alex Elder 2012-01-29 778 spin_lock(&rbd_client_list_lock); 602adf400201636 Yehuda Sadeh 2010-08-12 779 list_add_tail(&rbdc->node, &rbd_client_list); 432b858749631dc Alex Elder 2012-01-29 780 spin_unlock(&rbd_client_list_lock); 602adf400201636 Yehuda Sadeh 2010-08-12 781 37206ee5bede14d Alex Elder 2013-02-20 782 dout("%s: rbdc %p\n", __func__, rbdc); bc534d86be71aaf Alex Elder 2012-01-29 783 602adf400201636 Yehuda Sadeh 2010-08-12 784 return rbdc; 08f75463c15e26e Alex Elder 2013-05-29 785 out_client: 602adf400201636 Yehuda Sadeh 2010-08-12 786 ceph_destroy_client(rbdc->client); 08f75463c15e26e Alex Elder 2013-05-29 787 out_rbdc: 602adf400201636 Yehuda Sadeh 2010-08-12 788 kfree(rbdc); 602adf400201636 Yehuda Sadeh 2010-08-12 789 out_opt: 43ae47011232c1e Alex Elder 2012-07-03 790 if (ceph_opts) 43ae47011232c1e Alex Elder 2012-07-03 791 ceph_destroy_options(ceph_opts); 37206ee5bede14d Alex Elder 2013-02-20 792 dout("%s: error %d\n", __func__, ret); 37206ee5bede14d Alex Elder 2013-02-20 793 28f259b7cd78eb2 Vasiliy Kulikov 2010-09-26 794 return ERR_PTR(ret); 602adf400201636 Yehuda Sadeh 2010-08-12 795 } 602adf400201636 Yehuda Sadeh 2010-08-12 796 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
