Hi Jeff, I've been looking at xfstest generic/467 failure in cephfs, and I simply can not decide if it's a genuine bug on ceph kernel code. Since you've recently been touching the ceph_unlink code maybe you could help me understanding what's going on. generic/467 runs a couple of tests using src/open_by_handle, but the one failing can be summarized with the following: - get a handle to /cephfs/myfile using name_to_handle_at(2) - open(2) file /cephfs/myfile - unlink(2) /cephfs/myfile - drop caches - open_by_handle_at(2) => returns -ESTALE This test succeeds opening the handle with other (local) filesystems (maybe I should run it with other networked filesystem such as NFS). The -ESTALE is easy to trace to __fh_to_dentry, where inode->i_nlink is checked against 0. My question is: should we really be testing the i_nlink here? We dropped the name, but the file may still be there (as in this case). I guess I'm missing something, but hopefully you'll be able to shed some light on this. Thanks in advance for any help you may provide! Cheers, -- Luis
