Re: [PATCH] libceph: fix alloc_msg_with_page_vector() memory leaks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-03-10 20:50, Ilya Dryomov wrote:

[skip]

diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index 51810db4130a..998e26b75a78 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -962,7 +962,7 @@ static void ceph_osdc_msg_data_add(struct ceph_msg *msg,
 		BUG_ON(length > (u64) SIZE_MAX);
 		if (length)
 			ceph_msg_data_add_pages(msg, osd_data->pages,
-					length, osd_data->alignment);
+					length, osd_data->alignment, false);

Now I got the point when you were saying "that would break OSDs which
supply its own page vector". The callers of ceph_osdc_msg_data_add()
always own the pages, understood.

If necessary
Reviewed-by: Roman Penyaev <rpenyaev@xxxxxxx>

--
Roman




[Index of Archives]     [CEPH Users]     [Ceph Large]     [Ceph Dev]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux