On 2020/2/20 2:29, Jeff Layton wrote:
On Tue, 2020-02-18 at 22:38 -0500, xiubli@xxxxxxxxxx wrote:
From: Xiubo Li <xiubli@xxxxxxxxxx>
This will fulfill the cap hit/mis metric stuff per-superblock,
it will count the hit/mis counters based each inode, and if one
inode's 'issued & ~revoking == mask' will mean a hit, or a miss.
item total miss hit
-------------------------------------------------
caps 295 107 4119
URL: https://tracker.ceph.com/issues/43215
Signed-off-by: Xiubo Li <xiubli@xxxxxxxxxx>
---
fs/ceph/acl.c | 2 ++
fs/ceph/caps.c | 31 +++++++++++++++++++++++++++++++
fs/ceph/debugfs.c | 16 ++++++++++++++++
fs/ceph/dir.c | 9 +++++++--
fs/ceph/file.c | 2 ++
fs/ceph/mds_client.c | 26 ++++++++++++++++++++++----
fs/ceph/metric.h | 3 +++
fs/ceph/quota.c | 9 +++++++--
fs/ceph/super.h | 9 +++++++++
fs/ceph/xattr.c | 17 ++++++++++++++---
10 files changed, 113 insertions(+), 11 deletions(-)
Summary:
I think counting this stuff is useful, but I'm not sure you're doing it
in the right places below. Also, you're calling __ceph_caps_metric from
many places where you already know whether it's a hit or miss. You could
just bump the counter and do less work in those cases.
More notes below:
Will fix them all.
Thanks
BRs
Xiubo
