Re: Static Analysis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 13, 2019 at 5:04 AM Yuval Lifshitz <ylifshit@xxxxxxxxxx> wrote:
>
> Hi Brad,

Hi Yuval,

> Thanks for providing the script! I added 2 of the targets to the cmake
> system in this PR [1].
> Still working on scan-build.
> As a side note, on Fedora30, the iwyu version is pretty old, and
> create many false positives, I had to build and install from source.

I don't think adding additional dependencies to ceph for this is a
good idea. If we are to implement this, given this is strictly for
developers, I would suggest we make satisfying the dependencies for
these cmake options a manual process and avoid pulling in more
dependencies. What do you think?

>
> Yuval
>
> [1] https://github.com/ceph/ceph/pull/31579
>
> On Fri, Oct 11, 2019 at 8:45 AM Brad Hubbard <bhubbard@xxxxxxxxxx> wrote:
> >
> > On Thu, Oct 10, 2019 at 3:41 PM Yuval Lifshitz <ylifshit@xxxxxxxxxx> wrote:
> > >
> > > This is awesome!
> >
> > First thing to note is these scans each take a long time to run.
> >
> > > How difficult would it be to add these as cmake targets?
> >
> > With Coverity, currently impossible since the only version I can find
> > that works is not publicly available.
> >
> > As for the others I use the following script to run them so it
> > wouldn't be that hard I guess. There's some changes in there at the
> > moment to try and get them to only scan 'ceph code' (not submodule
> > code) but that seems to be confusing scan-build as it currently
> > produces zero results. I have some work to do there and there seems to
> > be a lot of maintenance work around these scans. I'm not sure how much
> > bang for our buck we would get by adding any of them as cmake targets.
> >
> > >
> > > On Thu, Oct 10, 2019 at 8:18 AM Brad Hubbard <bhubbard@xxxxxxxxxx> wrote:
> > >>
> > >> Latest static analyser results are up on  http://people.redhat.com/bhubbard/
> > >>
> > >> Weekly Fedora Copr builds are at
> > >> https://copr.fedorainfracloud.org/coprs/badone/ceph-weeklies/
> > >>
> > >>
> > >> --
> > >> Cheers,
> > >> Brad
> > >> _______________________________________________
> > >> Dev mailing list -- dev@xxxxxxx
> > >> To unsubscribe send an email to dev-leave@xxxxxxx
> >
> >
> >
> > --
> > Cheers,
> > Brad
>


-- 
Cheers,
Brad





[Index of Archives]     [CEPH Users]     [Ceph Large]     [Ceph Dev]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux