On Mon, Jul 08, 2019 at 03:48:08PM +0200, Arnd Bergmann wrote:
> clang points out a -Wsometimed-uninitized bug in the modified
> ceph_real_mount() function:
>
> fs/ceph/super.c:850:6: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> if (!fsc->sb->s_root) {
> ^~~~~~~~~~~~~~~~
> fs/ceph/super.c:885:9: note: uninitialized use occurs here
> return err;
> ^~~
> fs/ceph/super.c:850:2: note: remove the 'if' if its condition is always true
> if (!fsc->sb->s_root) {
> ^~~~~~~~~~~~~~~~~~~~~~
> fs/ceph/super.c:843:9: note: initialize the variable 'err' to silence this warning
> int err;
> ^
> = 0
>
> Set it to zero if the condition is false.
>
> Fixes: 108f95bfaa56 ("vfs: Convert ceph to use the new mount API")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Thanks for the patch!
Reviewed-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
