Re: [PATCH] ceph: fix "ceph.dir.rctime" vxattr value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 15, 2019 at 5:47 PM Sage Weil <sage@xxxxxxxxxxxx> wrote:
>
> On Wed, 15 May 2019, David Disseldorp wrote:
> > The vxattr value incorrectly places a "09" prefix to the nanoseconds
> > field, instead of providing it as a zero-pad width specifier after '%'.
> >
> > Link: https://tracker.ceph.com/issues/39943
> > Fixes: 3489b42a72a4 ("ceph: fix three bugs, two in ceph_vxattrcb_file_layout()")
> > Signed-off-by: David Disseldorp <ddiss@xxxxxxx>
> > ---
> >
> > @Yan, Zheng: given that the padding has been broken for so long, another
> >              option might be to drop the "09" completely and keep it
> >              variable width.
>
> Since the old value was just wrong, I'd just make it correct here and not
> worry about compatibility with a something that wasn't valid anyway.

(Chiming in because I can't parse whether you want David to keep "09"
or drop it...)

FWIW it's zero-padded in ceph_read_dir():

  "rctime:    %10lld.%09ld\n"

Not sure if anyone actually mounts with -o dirstat and does reads on
directories, but I'd keep "09" for consistency.

Thanks,

                Ilya



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux