[ceph-client:ceph-async-unlink 2/2] fs//ceph/dir.c:1083:8: error: implicit declaration of function 'try_get_cap_refs'; did you mean 'ceph_get_cap_refs'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://github.com/ceph/ceph-client.git ceph-async-unlink
head:   30ea3912c98431811b0aa7dcf7bf725aa0a80f91
commit: 30ea3912c98431811b0aa7dcf7bf725aa0a80f91 [2/2] ceph: update async dir operations handling
config: i386-randconfig-x001-201919 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout 30ea3912c98431811b0aa7dcf7bf725aa0a80f91
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   fs//ceph/dir.c: In function 'get_caps_for_async_unlink':
>> fs//ceph/dir.c:1083:8: error: implicit declaration of function 'try_get_cap_refs'; did you mean 'ceph_get_cap_refs'? [-Werror=implicit-function-declaration]
     ret = try_get_cap_refs(ci, 0, want, 0, true, &got);
           ^~~~~~~~~~~~~~~~
           ceph_get_cap_refs
>> fs//ceph/dir.c:1085:6: error: 'err' undeclared (first use in this function)
     if (err != 1 || got != want)
         ^~~
   fs//ceph/dir.c:1085:6: note: each undeclared identifier is reported only once for each function it appears in
   cc1: some warnings being treated as errors

vim +1083 fs//ceph/dir.c

  1075	
  1076	static bool get_caps_for_async_unlink(struct inode *dir, struct dentry *dentry)
  1077	{
  1078		struct ceph_inode_info *ci = ceph_inode(dir);
  1079		struct ceph_dentry_info *di;
  1080		int ret, want, got;
  1081	
  1082		want = CEPH_CAP_FILE_EXCL | CEPH_CAP_DIR_UNLINK;
> 1083		ret = try_get_cap_refs(ci, 0, want, 0, true, &got);
  1084		dout("Fx on %p ret=%d got=%d\n", dir, ret, got);
> 1085		if (err != 1 || got != want)
  1086			return false;
  1087	
  1088	        spin_lock(&dentry->d_lock);
  1089	        di = ceph_dentry(dentry);
  1090		/* - We are holding CEPH_CAP_FILE_EXCL, which implies
  1091		 * CEPH_CAP_FILE_SHARED.
  1092		 * - Only support async unlink for primary linkage */
  1093		if (atomic_read(&ci->i_shared_gen) != di->lease_shared_gen ||
  1094		    !(di->flags & CEPH_DENTRY_PRIMARY_LINK))
  1095			ret = 0;
  1096	        spin_unlock(&dentry->d_lock);
  1097	
  1098		if (!ret) {
  1099			ceph_put_cap_refs(ci, got);
  1100			return false;
  1101		}
  1102		return true;
  1103	}
  1104	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux