On Thu, 18 Apr 2019 10:57:14 +0800, Yan, Zheng wrote: > > +static bool ceph_vxattrcb_snap_btime_exists(struct ceph_inode_info *ci) > > +{ > > + return (ci->i_snap_btime.tv_sec != 0 && ci->i_snap_btime.tv_nsec != 0); > > this should be return (ci->i_snap_btime.tv_sec != 0 || > ci->i_snap_btime.tv_nsec != 0); Good catch, will fix and resend. FWIW, the libcephfs changes use !in->snap_btime.is_zero(), so don't carry this error. Cheers, David