Re: Clang complain about rather long standing code.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It would be from "librbd: improve object map performance under high
IOPS workloads" I suspect. Perhaps adding a default constructor here
[1] would solve the problem?

Jason

[1] https://github.com/ceph/ceph/blob/master/src/common/bit_vector.hpp#L227

On Tue, Mar 12, 2019 at 8:50 AM Willem Jan Withagen <wjw@xxxxxxxxxxx> wrote:
>
> Hi,
>
> This is an error in code back from 2014, where I don't get what went
> wrong al of a sudden.
>
> My CI-jenkins takes a few PR's at the time so I have more that one
> possible candidate for the cause
> Any of the following changes, make Clang complain and error out:
>
>      qa/suites/krbd: enable deep-flatten feature (detail / githubweb)
>      test/librbd: observe the object map interaction in
> DiscardRemoveTruncate (detail / githubweb)
>      librbd: don't do create+truncate for discards with copyup (detail /
> githubweb)
>      test/librbd: create shouldn't be called in (detail / githubweb)
>      qa: krbd deep-flatten test (detail / githubweb)
>      build/rgw: unittest_rgw_dmclock_scheduler does not need
> Boost_LIBRARIES (detail / githubweb)
>      librbd: improve object map performance under high IOPS workloads
> (detail / githubweb)
>      mgr/dashboard: Change 'Client Recovery' title (detail / githubweb)
>      mgr/MgrStandby: exit with 0 result code, as if we'd done an orderly
> (detail / githubweb)
>
> If this does not ring I bell, I'll have to start disecting.
>
> --WjW
>
> http://cephdev.digiware.nl:8180/jenkins/job/ceph-master/3130/consoleFull
>
>
> In file included from
> /home/jenkins/workspace/ceph-master/src/cls/rbd/cls_rbd.cc:28:
> In file included from
> /home/jenkins/workspace/ceph-master/src/objclass/../include/types.h:21:
> In file included from
> /home/jenkins/workspace/ceph-master/src/include/uuid.h:8:
> In file included from
> /home/jenkins/workspace/ceph-master/src/include/encoding.h:17:
> In file included from /usr/include/c++/v1/set:426:
> In file included from /usr/include/c++/v1/__tree:16:
> /usr/include/c++/v1/memory:2241:41: error: call to implicitly-deleted
> default constructor of
> '__compressed_pair_elem<ceph::BitVector<'\x02'>::NoInitAllocator, 1>'
>        : _Base1(std::forward<_Tp>(__t)), _Base2() {}
>                                          ^
> /usr/include/c++/v1/vector:437:7: note: in instantiation of function
> template specialization 'std::__1::__compressed_pair<unsigned int *,
> ceph::BitVector<'\x02'>::NoInitAllocator>::__compressed_pair<nullptr_t,
> true>' requested here
>        __end_cap_(nullptr)
>        ^
> /usr/include/c++/v1/vector:496:5: note: in instantiation of member
> function 'std::__1::__vector_base<unsigned int,
> ceph::BitVector<'\x02'>::NoInitAllocator>::__vector_base' requested here
>      vector()
> _NOEXCEPT_(is_nothrow_default_constructible<allocator_type>::value)
>      ^
> /home/jenkins/workspace/ceph-master/src/common/bit_vector.hpp:163:3:
> note: in instantiation of member function 'std::__1::vector<unsigned
> int, ceph::BitVector<'\x02'>::NoInitAllocator>::vector' requested here
>    BitVector();
>    ^
> /home/jenkins/workspace/ceph-master/src/cls/rbd/cls_rbd.cc:3289:16:
> note: in instantiation of member function
> 'ceph::BitVector<'\x02'>::BitVector' requested here
>    BitVector<2> object_map;
>                 ^
> /usr/include/c++/v1/memory:2179:39: note: explicitly defaulted function
> was implicitly deleted here
>    _LIBCPP_INLINE_VISIBILITY constexpr __compressed_pair_elem() = default;
>                                        ^
> /usr/include/c++/v1/memory:2172:50: note: default constructor of
> '__compressed_pair_elem<ceph::BitVector<'\x02'>::NoInitAllocator, 1,
> true>' is implicitly deleted because base class
> 'ceph::BitVector<'\x02'>::NoInitAllocator' has no default constructor
> struct __compressed_pair_elem<_Tp, _Idx, true> : private _Tp {
>                                                   ^
> 1 error generated.
> gmake[2]: *** [src/cls/CMakeFiles/cls_rbd.dir/build.make:63:
> src/cls/CMakeFiles/cls_rbd.dir/rbd/cls_rbd.cc.o] Error 1
> gmake[2]: *** Waiting for unfinished jobs....



-- 
Jason



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux