Thanks Sebastian. I wonder how the error reporting out of the manager can be improved. For example, there was no stack trace associated with that TypeError. So walking through the code paths by hand is fine, it's definitely useful to see those more verbose errors. I wonder if this has something to do with the cross-module call machinery. On Tue, Jan 22, 2019 at 12:24 AM Sebastian Wagner <swagner@xxxxxxxx> wrote: > > The interface has changed a bit: > > > https://github.com/noahdesu/ceph/commit/bd1d97d16a6fa9ddd19cfb0f4e3888c6ed17bac1#r32017893 > > > > Am 21.01.19 um 23:25 schrieb Noah Watkins: > > That's all that's printed, and there is only barely more helpful > > output in the log. > > > > 2019-01-21 13:18:21.383 7f0797f6f700 0 log_channel(audit) log [DBG] : > > from='client.4141 v2:192.168.121.1:36122/2428292329' > > entity='client.admin' cmd=[{"prefix": "orchestrator host add", "host": > > "osd0", "target": ["mgr", ""]}]: dispatch > > 2019-01-21 13:18:21.384 7f0798770700 -1 mgr handle_command module > > 'orchestrator_cli' command handler threw exception: _oremote() missing > > 1 required positional argument: 'kwargs' > > 2019-01-21 13:18:21.384 7f0798770700 -1 mgr.server reply reply (22) > > Invalid argument TypeError: _oremote() missing 1 required positional > > argument: 'kwargs' > > > > It's probably related to the orch. cli interfaces I added, but they > > seem to be operating similarly to the others: > > https://github.com/noahdesu/ceph/commit/bd1d97d16a6fa9ddd19cfb0f4e3888c6ed17bac1 > > > > On Mon, Jan 21, 2019 at 2:13 PM Sebastian Wagner <swagner@xxxxxxxx> wrote: > >> > >> Do you have a full stacktrace for me? > >> > >> Am 21.01.19 um 22:26 schrieb Noah Watkins: > >>> Hey Sebastian, > >>> > >>> I was updated my tree this morning and noticed the orchestrator > >>> throwing a type error: > >>> > >>> [nwatkins@daq build]$ bin/ceph orchestrator host add osd0 > >>> Error EINVAL: TypeError: _oremote() missing 1 required positional > >>> argument: 'kwargs' > >>> > >>> It looks like the typing was added in > >>> https://github.com/ceph/ceph/commit/80b3a05c33329e59be63ceb207094d469be1216b > >>> > >>> but I don't see any changes adapting existing _oremote interface or > >>> callers, so it's a bit confusing what needs to happen. are there any > >>> recommended docs to read to help decipher this? > >>> > >>> - Noah > >>> > >> > >> -- > >> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, > >> HRB 21284 (AG Nürnberg) > > > > -- > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, > HRB 21284 (AG Nürnberg)
