Am 03.12.18 um 14:02 schrieb Jan Fajerski: > On Fri, Nov 30, 2018 at 02:56:01PM +0100, Sebastian Wagner wrote: >> >> >> Am 30.11.18 um 14:34 schrieb Sage Weil: >> >>> >>> Current example: I'm using format_bytes() from the status module from >>> the >>> pg_autoscaler module via remote(), which is probably not ideal! >> >> Perfect example! We have a very similar function in >> /src/ceph-volume/ceph_volume/util/disk.py called human_readable_size. We >> don't have any common place for shared Python code right now. > This is ceph-volume though. Are we talking about shared code between all > python pieces within ceph? I'm sure there're plenty of opportunities for > shared implementations within ceph, but this would be a major > reorganisation and will likely require implementation changes. Both. Sharing code between MGR modules is easy: just move code to the shared `mgr` folder. On the other hand, sharing code between different Ceph components is the hard part, indeed. > > A mgr_util.py for mgr modules seems like a step in the right direction though. >> >> >>> >>> s >>> >>> >> > -- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
