On 23/11/2018 22:50, Willem Jan Withagen wrote:
Since a few builds my FreeBSD jenkins run do not complete because
libmds is not there.
I'm not sure why libmds isn't getting build and why the makefile tries
to link with -Lmds.
(I guess that later is because there is no libmds in ../../../lib)
Now given that the regular jenkins builds complete, it has to do with
FreeBSD building.
And I do build with CEPHFS, trigiring:
if (WITH_CEPHFS)
add_subdirectory(mds)
set(ceph_mds_srcs
ceph_mds.cc)
add_executable(ceph-mds ${ceph_mds_srcs})
target_link_libraries(ceph-mds mds ${CMAKE_DL_LIBS} global-static
ceph-common
Boost::thread)
install(TARGETS ceph-mds DESTINATION bin)
endif()
Now the key questions is: Does ceph-dencode really require libmds?
I'm currently building with the
add_subdirectory(mds)
lifted out the conditional
Answering my own question.
That fixes this part, I'll submit a PR.
But then there are more intricate combinations of
WITH_CEPHFS, WITH_LIBCEPHFS, WITH_KRBD, and perhaps more.
If I figure out how this interconnects, I'm tempted to augment this as
well.
--WjW
