On Mon, Sep 24, 2018 at 8:03 AM Sage Weil <sweil@xxxxxxxxxx> wrote: > - do_cmake.sh is updated to -DCMAKE_BUILD_TYPE=Debug by default. This > means you get the debug ceph::mutex version (that does lockdep). It also > means optimizations are turned down so you can gdb through core files > with less pain from symbols optimized away. :) Yay! > - The only code that has been converted to ceph::mutex so far is Finisher. > You can see what that transition looks like here: > > https://github.com/ceph/ceph/pull/24133/commits/8535965ba4298537c489897ccb191a0f458d60d7 > > - lock("Foo::lock") -> lock(ceph::make_mutex("Foo::lock")) in ctor It's odd seeing what looks like a move/copy constructed mutex. If I'm understanding the `make_mutex` code correctly, this just selectively discards the arguments to the lock ctor if not debug mode? -- Patrick Donnelly
