"Yan, Zheng" <ukernel@xxxxxxxxx> writes: >> +int ceph_osdc_copy_from(struct ceph_osd_client *osdc, >> + struct ceph_vino src_vino, > > using vino is confusing. It's better to just pass snapid here. Yeah, that probably makes sense -- we only care about the .snap member in this ceph_vino. I'll change that in v2. Cheers, -- Luis