Re: [PATCH 2/4] libceph: introduce cls_journaler_client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/16/2018 09:15 AM, Ilya Dryomov wrote:
>>> +//TODO get all metas in one single request
>> You should get rid of "TODO" comments; if it's a to-do item, describe the
>> work to be done elsewhere (like a tracker entry).
> This is a matter of taste, but I disagree, especially for RFC patches.
> These comments are valuable because they are localized to a block of
> code and make it easy to see what is intended to be revisited without
> referencing the cover letter or, worse, some tracker.

OK with me.  I agree it's a matter of taste, and it's really a minor point.

					-Alex



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux