rbd was not run on 22680 :( and therefor unit formatting changes were missed (it was not clear from the PR tags that rbd should be part of testing) Can we address [3] and [4] without lot of effort? Or should we consider reverting 22680? We also can consider addressing it in next point 12.2.9 On Wed, Aug 15, 2018 at 10:51 AM, Jason Dillaman <jdillama@xxxxxxxxxx> wrote: > On Wed, Aug 15, 2018 at 12:22 PM Abhishek Lekshmanan <abhishek@xxxxxxxx> > wrote: >> >> Hi list, >> >> We've had 100+ prs merged post 12.2.7, during the last month, and are >> currently waiting for 3 more expected to go in today. The current list >> of prs that went in after 12.2.7 can be found with: >> >> https://github.com/ceph/ceph/pulls?q=label%3A12.2.8+is%3Aclosed >> >> @leads, are we ready to cut 12.2.8 and begin the final qe process? > > > Can we pull in [1]? Also, it appears that the current luminous branch has > pulled in some unit formatting changes ([2]?) that are causing tests to fail > [3][4]. > >> -- >> Abhishek > > > [1] https://github.com/ceph/ceph/pull/23594 > [2] https://github.com/ceph/ceph/pull/22680 > [3] http://tracker.ceph.com/issues/26927 > [4] http://tracker.ceph.com/issues/26928 > -- > Jason
