On Mon, Jul 23, 2018 at 6:13 AM Laura Paduano <lpaduano@xxxxxxxx> wrote: > > Hi all, > > I've created a pull request which is supposed run our Ceph mgr dashboard > frontend (e2e) tests. [1] > In oder to run those tests, we need a compiled Ceph around on the system. > So I was wondering how to integrate this into the Jenkins job.. > I guess one option would be to include the run-make-check script > like it's used in the ceph-pull-request Jenkins job [2] ? > Or is there any other way? This isn't my expertise, but there definitely isn't an established pattern to follow here. You may have noticed that so far the Jenkins-based tests predominantly either 1) build ceph, as in the build-and-make-check jobs that run on PRs, or 2) are used for ceph-ansible, which itself deploys Ceph from packages. There are also the ceph-volume tests, which probably do turn on a cluster, so you could look to see if they're doing something else? Otherwise, there are two basic paths: 1) You can install from packages, either full releases or dev packages built off master branch etc, 2) You can build it again locally based on the git repo you're testing the dashboard for. Those will have different tradeoffs and I'm not sure what dominates for the dashboard. (For instance, how often do dashboard PRs include required changes to other Ceph systems?) Hopefully if you do decide to do your own builds you can somehow integrate with the existing per-PR tests that happen, or turn those off in favor of your larger job. It's not critical but those builds do take up some time so it'd be nice not to re-do them unless necessary. -Greg > > > [1] https://github.com/ceph/ceph-build/pull/1086 > [2] https://github.com/ceph/ceph-build/blob/master/ceph-pull-requests/config/ > definitions/ceph-pull-requests.yml#L56 > > > Feedback/ideas/reviews are much appreciated! :) > > Thanks in advance, > Laura > > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
