On Mon, 23 Jul 2018, John Spray wrote: > Hi all, > > Shall we have a pull request template on github? > > We mainly care about git commit style rather than the PR message > itself, so I thought it might be useful to put info about that in > there, along with a link to SubmittingPatches.rst for more. > > https://github.com/ceph/ceph/pull/23185 Does the <!-- ... --> mean they'll see this but it won't end up in the PR description? If so, then +1. I'd maybe add a bit that the PR title should also follow the "[component]: [short description]" format. In the PR body itself we could also do something like - [ ] References tracker ticket (bug or feature) - [ ] Updates documentation references (if any) - [ ] Updates tests in qa/ to reproduce the original bug or test new feature ? sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
