On Wed, Jun 27, 2018 at 3:05 PM Chengguang Xu <cgxu519@xxxxxxx> wrote:
>
> There is no reason to continue option parsing after detecting
> bad option.
>
> Signed-off-by: Chengguang Xu <cgxu519@xxxxxxx>
> ---
> net/ceph/ceph_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c
> index 584fdbef2088..a75f1640f50a 100644
> --- a/net/ceph/ceph_common.c
> +++ b/net/ceph/ceph_common.c
> @@ -398,7 +398,7 @@ ceph_parse_options(char *options, const char *dev_name,
> if (ret < 0) {
> pr_err("bad mount option arg (not int) "
> "at '%s'\n", c);
> - continue;
> + goto out;
> }
> dout("got int token %d val %d\n", token, intval);
> } else if (token > Opt_last_int && token < Opt_last_string) {
Applied, merging in an error handling change. See
https://github.com/ceph/ceph-client/commit/0dab2020c9a77b5604f0506fda0062e2539791e1.
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
