On Thu, Jun 14, 2018 at 10:17:35AM +0800, kefu chai wrote:
On Thu, Jun 14, 2018 at 9:22 AM Victor Denisov <denisovenator@xxxxxxxxx> wrote:
Hi,
I'm cherrypicking this change to luminous:
ab7899582f668e40947161128312d17a18fc3a23
The whole list of changes is:
f931942e46 common/options: change mon_data_size_warn type to TYPE_SIZE
61504f117c qa/workunits/cephtool/test.sh: fix SI unit test, add IEC unit test
ab7899582f common/options: parse TYPE_SIZE with iec unit prefixes (base 2)
143c776ba3 common/strtol: add string_view interface and use
string_view internally
a3739cbb3c common/util: remove unit_to_bytesize, use strict_iecstrtoll instead
f753b74f37 common/strtol: add strict_iecstrtoll; strict_sistrtoll uses base 10
d3cecebacd include/types: format decimal numbers with decimal factor
But the code that this patch changes doesn't exist in luminous.That
code was introduced by an earlier patch in master and introduces some
code for working with TYPE_SIZE.
probably we can skip ab7899582f668e40947161128312d17a18fc3a23, as
strictly speaking, i think, it's more of a feature, instead of a bug
fix.
@Jan, what do you think?
yes ab7899583f668e40947161128312d17a18fc3a23 can be skipped if the code it
changes doesn't exist in luminous.
@Victor You probably want to have a good look at the test suite after your
backport to make sure all string parsing and printing work correctly. Also you
might want to include
c5e6f6b0a4e088b458e9a303a3bb0cf16fd036fb and
dc081d49c85b74d2436cc3e2f6a1a8eb63234a5a. This fixes parsing of hex numbers and
adds a test for parsing hexadecimal numbers.
Should that other code, that introduces the code that I patch, be ported?
Thanks,
Victor.
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards
Kefu Chai
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Fajerski
Engineer Enterprise Storage
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
