On Thu, May 31, 2018 at 8:08 AM, Liu, Chunmei <chunmei.liu@xxxxxxxxx> wrote: > -----Original Message----- > From: kefu chai [mailto:tchaikov@xxxxxxxxx] > Sent: Wednesday, May 30, 2018 12:05 AM > To: Liu, Chunmei <chunmei.liu@xxxxxxxxx> > Cc: ceph-devel <ceph-devel@xxxxxxxxxxxxxxx>; Kefu Chai <kchai@xxxxxxxxxx> > Subject: Re: wip-seastar branch build issue > > On Wed, May 30, 2018 at 6:10 AM, Liu, Chunmei <chunmei.liu@xxxxxxxxx> wrote: >> >> Hi kefu, >> >> Please modify ceph/wip-seastar branch src/seastar @ 6ffa185/.gitmodules, it is not point to scylladb, I can't modify it locally, every time it re-checkout seastar folder. > > Chunmei, just pointed wip-seastar src/seastar to the commit containing the .gitmodules change. sorry for the inconvenience. > > Kefu, can it only build unittest_seastar_echo object or whole ceph? I build whole ceph failed. unittest_seastar_echo build success. what FTBFS is unittest_throttle. > > Kefu, something wrong in src/test/common/Throttle.cc, after you change Throttle.get() from bool to void. Are you sure we need change Throttle.get() from the bool to void or we reverse it? i thought the bool retval is not used in production code, so removed it. but turns out it is used by the unittest, i am reverting that change at this moment. please pull the latest wip-seastar. > >> >> Thanks! >> -Chunmei >> -- >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" >> in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo >> info at http://vger.kernel.org/majordomo-info.html > > > > -- > Regards > Kefu Chai -- Regards Kefu Chai -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
