Re: [PATCH] ceph: fix alignment of rasize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On May 30, 2018, at 10:13, Chengguang Xu <cgxu519@xxxxxxx> wrote:
> 
> Fix improper rasize alignment.
> 
> Based on code, rasize(max readahead) actually aligns to PAGESIZE not
> 1024 which is documented in below link, should fix the document as well.
> 
> docs.ceph.com/docs/master/man/8/mount.ceph/
> 
> Signed-off-by: Chengguang Xu <cgxu519@xxxxxxx>
> ---
> fs/ceph/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ceph/super.c b/fs/ceph/super.c
> index b33082e6878f..465861959a6b 100644
> --- a/fs/ceph/super.c
> +++ b/fs/ceph/super.c
> @@ -268,7 +268,7 @@ static int parse_fsopt_token(char *c, void *private)
> 	case Opt_rasize:
> 		if (intval < 0)
> 			return -EINVAL;
> -		fsopt->rasize = ALIGN(intval + PAGE_SIZE - 1, PAGE_SIZE);
> +		fsopt->rasize = ALIGN(intval, PAGE_SIZE);

if intval is 2048, ALIGN(intval, PAGE_SIZE) is 0.  why do you want to make this change?

> 		break;
> 	case Opt_caps_wanted_delay_min:
> 		if (intval < 1)
> -- 
> 2.17.0
> 

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux