On 05/14/2018 02:57 PM, Willem Jan Withagen wrote:
On 14-5-2018 17:50, Casey Bodley wrote:
On 05/14/2018 11:30 AM, Willem Jan Withagen wrote:
Hi,
Anybody a suggestion as to why this started throwing errors??
All runs during my vacation failed on a compile error due to an missing
include, but once I fixed that I get the thing below.
Any option flags to get more data out of the run?
Thanx
--WjW
wjw@cephdev:~/master % ./build/bin/unittest_async_shared_mutex
Running main() from gmock_main.cc
[==========] Running 11 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 11 tests from SharedMutex
[ RUN ] SharedMutex.async_exclusive
[ OK ] SharedMutex.async_exclusive (0 ms)
[ RUN ] SharedMutex.async_shared
[ OK ] SharedMutex.async_shared (1 ms)
[ RUN ] SharedMutex.async_exclusive_while_shared
[ OK ] SharedMutex.async_exclusive_while_shared (0 ms)
[ RUN ] SharedMutex.async_shared_while_exclusive
[ OK ] SharedMutex.async_shared_while_exclusive (0 ms)
[ RUN ] SharedMutex.async_prioritize_exclusive
Abort
--
To unsubscribe from this list: send the line "unsubscribe
ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Willem,
Hi Casey,
This is a new test that merged last week with
https://github.com/ceph/ceph/pull/21914.
Yup, saw that with git blame... :)
It's working locally with clang, but I haven't tested with libc++.
Are you able to get a stack trace? I'll try setting up a freebsd vm
to reproduce.
Let me know what you find. Need to do some business work first
tonight, but the diff is only a mising include file to get things
compiling again.
--WjW
p.s. can you tell if the missing include is related to that pr as well?
index f71928fd83..8dcdab612a 100644
--- a/src/common/async/shared_mutex.h
+++ b/src/common/async/shared_mutex.h
@@ -17,6 +17,7 @@
#include <condition_variable>
#include <mutex>
+#include <optional>
#include <shared_mutex> // for std::shared_lock
#include <boost/intrusive/list.hpp>
Hi Willem,
I was able to reproduce and root cause the issue - I opened
http://tracker.ceph.com/issues/24124 and
https://github.com/ceph/ceph/pull/21986 to revert the commit that
introduces this class until I have a chance to rework the design. The
class is currently unused but ongoing work in
https://github.com/ceph/ceph/pull/21271 depends on it.
Thanks,
Casey
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
