On Tue, 24 Apr 2018, Adam C. Emerson wrote:
I have thought off and on and chatted with a few others about the using a binary log, since the runtime cost of all that stringification at high log levels is Not Insignificant.
+1 /but/ also the fewer times we log individual items in general the better.
If we required that only contiguous objects could be logged (or continguous subobjects.
Seems like a step in the right direction. Another question is "are there any situations where we'd need to a non-contiguous object", with the corrolary question "are there situations where serializing a non-contiguous object into a contiguous one would be both necessary and truly prohibitive"?
Even using encode/decode would probably be an improvement over straight-up stringification.
Quite possible. At least, worth measuring if we can.
We could possibly make a macro for logging that implicitly constructs a lambda that's only evaluated if the log level is high enough.
There may also be ways to make such a lambda empty (and optimized away). -Jesse -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
