On Sat, Mar 17, 2018 at 3:59 AM, Alex Elder <elder@xxxxxxxxxx> wrote:
> On 03/16/2018 07:37 AM, Alex Elder wrote:
>> From: Ilya Dryomov <idryomov@xxxxxxxxx>
>>
>> In preparation for rbd "fancy" striping, introduce ceph_bvec_iter for
>> working with bio_vec array data buffers. The wrappers are trivial, but
>> make it look similar to ceph_bio_iter.
>>
>> Signed-off-by: Ilya Dryomov <idryomov@xxxxxxxxx>
>
> I'm not going to review this until you've corrected your terrible ways
> on ceph_bio_iter_advance_step(). :)
>
> Same comments apply here. The way you are using macros looks
> clean but it is hard for the reader (me anyway) to follow. It
> can be done more directly with functions and function pointers,
> and I think the result is more maintainable and just as efficient.
See my other reply.
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
