Re: [PATCH] rbd: Remove VLA stack usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 12, 2018 at 6:06 AM, Tobin C. Harding <me@xxxxxxxx> wrote:
> On Sun, Mar 11, 2018 at 10:02:04PM -0700, Eric Biggers wrote:
>> On Mon, Mar 12, 2018 at 03:49:40PM +1100, Tobin C. Harding wrote:
>> > The kernel would like to have all stack VLA usage removed[1].
>>
>> Can you please stop writing this?  The Linux kernel isn't sentient; it doesn't
>> "like" anything.  You need to explain why *you* (and other people) believe these
>> changes should be made.
>
> No worries, will re-spin with better description.

I'd prefer a single patch covering both functions.

Also, as these are char arrays, use sizeof instead of ARRAY_SIZE.

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux