Found this near the bottom of my inbox today... On Mon, Jan 29, 2018 at 8:28 PM, TYLin <wooertim@xxxxxxxxx> wrote: > Hi all, > > We found that cache-tier forward mode is hanging in luminous 12.2.1. It seems that the client is keep sending request to cache-tier's osd and the osd always replied redirect to client. This seems due to this patch: > > https://github.com/ceph/ceph/commit/9adb68f5e206c167b97ec89935cbdaeb462173d8#diff-847b3447bebb2f031678eef0a2aea60d > > I added “CEPH_OSD_FLAG_IGNORE_OVERLAY” to the op to force it skips cache-tier when client got redirect reply and it seems to work. Is there any potential issue of adding this flag here? > > in src/osdc/Objecter.cc > void Objecter::handle_osd_op_reply(MOSDOpReply *m) > { > … > … > if (m->is_redirect_reply()) { > … > op->target.flags |= (CEPH_OSD_FLAG_REDIRECTED | CEPH_OSD_FLAG_IGNORE_OVERLAY); > ... > } > } This does indeed look right to me; we only issue a redirect reply for the weirder caching modes and when we get them we definitely do want the Objecter's target calculations to ignore overlays! Can you send in a PR for this fix? :) -Greg -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
