Re: [PATCH v2] ceph: use seq_show_option for string type options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 15, 2018 at 8:39 AM, Chengguang Xu <cgxu519@xxxxxxxxxx> wrote:
> Using seq_show_option to replace seq_printf for string type options.
>
> Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxx>
> ---
> Changes since v1:
> - Code cleanup for showing fscache related options.
>
>  fs/ceph/super.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/fs/ceph/super.c b/fs/ceph/super.c
> index a62d2a9..f9418d4 100644
> --- a/fs/ceph/super.c
> +++ b/fs/ceph/super.c
> @@ -511,10 +511,7 @@ static int ceph_show_options(struct seq_file *m, struct dentry *root)
>         if ((fsopt->flags & CEPH_MOUNT_OPT_DCACHE) == 0)
>                 seq_puts(m, ",nodcache");
>         if (fsopt->flags & CEPH_MOUNT_OPT_FSCACHE) {
> -               if (fsopt->fscache_uniq)
> -                       seq_printf(m, ",fsc=%s", fsopt->fscache_uniq);
> -               else
> -                       seq_puts(m, ",fsc");
> +               seq_show_option(m, "fsc", fsopt->fscache_uniq);
>         }
>         if (fsopt->flags & CEPH_MOUNT_OPT_NOPOOLPERM)
>                 seq_puts(m, ",nopoolperm");
> @@ -527,7 +524,7 @@ static int ceph_show_options(struct seq_file *m, struct dentry *root)
>  #endif
>
>         if (fsopt->mds_namespace)
> -               seq_printf(m, ",mds_namespace=%s", fsopt->mds_namespace);
> +               seq_show_option(m, "mds_namespace", fsopt->mds_namespace);
>         if (fsopt->wsize)
>                 seq_printf(m, ",wsize=%d", fsopt->wsize);
>         if (fsopt->rsize != CEPH_MAX_READ_SIZE)

Applied.

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux