On Tue, Feb 13, 2018 at 2:30 AM, Chengguang Xu <cgxu519@xxxxxxxxxx> wrote: > Using seq_show_option to replace seq_printf for string type options. > > Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxx> > --- > fs/ceph/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ceph/super.c b/fs/ceph/super.c > index a62d2a9..d8a33ad 100644 > --- a/fs/ceph/super.c > +++ b/fs/ceph/super.c > @@ -512,7 +512,7 @@ static int ceph_show_options(struct seq_file *m, struct dentry *root) > seq_puts(m, ",nodcache"); > if (fsopt->flags & CEPH_MOUNT_OPT_FSCACHE) { > if (fsopt->fscache_uniq) > - seq_printf(m, ",fsc=%s", fsopt->fscache_uniq); > + seq_show_option(m, "fsc", fsopt->fscache_uniq); > else > seq_puts(m, ",fsc"); Hi Chengguang, seq_show_option() should be able to handle !fsopt->fscache_uniq? Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html