Hi Ilya I looked at nfs code of option parsing and found nfs is the same as ceph, but in 9P fscache related options are carefully surrounded by CONFIG_9P_FSCACHE, if you agree this I’ll make a patch to handle this in ceph. Thanks, Chengguang. > 在 2018年1月30日，下午9:39，Ilya Dryomov <idryomov@xxxxxxxxx> 写道： > > On Tue, Jan 30, 2018 at 2:17 PM, Chengguang Xu <cgxu519@xxxxxxxxxx> wrote: >> Hi Zheng, Ilya >> >> Recently I’ve just tested some mount option of cephfs and found though >> fscache kernel module was disabled but when I specified -o fsc to mount.ceph >> there is no any indication of warning or failure. >> >> I think it may cause enduser's misunderstanding of fscache function, >> so I plan to add extra checks to parsing fscache related options in kernel side. >> >> There are two approaches as below, could you tell me which will be better? >> >> If we get conflict condition about fscache. >> >> A. Print error message && Exit mount immediately >> >> B. Only print error message but continue mount process. > > Hi Chengguang, > > I'd look at and follow nfs behaviour here. > > Thanks, > > Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
