On Fri, Jan 26, 2018 at 7:54 AM, Chengguang Xu <cgxu519@xxxxxxxxxx> wrote: > Should check result of kstrndup() in case of memory allocation failure. > > Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxx> > --- > net/ceph/ceph_common.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c > index 5c036d2..1e492ef 100644 > --- a/net/ceph/ceph_common.c > +++ b/net/ceph/ceph_common.c > @@ -421,6 +421,10 @@ struct ceph_options * > opt->name = kstrndup(argstr[0].from, > argstr[0].to-argstr[0].from, > GFP_KERNEL); > + if (!opt->name) { > + err = -ENOMEM; > + goto out; > + } > break; > case Opt_secret: > opt->key = kzalloc(sizeof(*opt->key), GFP_KERNEL); Applied. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html