From: Fengguang Wu <fengguang.wu@xxxxxxxxx> fs/ceph/export.c:357:33-39: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 961bfcf78c8f ("[DO NOT MERGE] ceph: snapshot nfs re-export") CC: Yan, Zheng <zyan@xxxxxxxxxx> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> --- export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ceph/export.c +++ b/fs/ceph/export.c @@ -354,7 +354,7 @@ static struct dentry *ceph_get_parent(st } out: dout("get_parent %p ino %llx.%llx err=%ld\n", - child, ceph_vinop(inode), (IS_ERR(dn) ? PTR_ERR(dn) : 0)); + child, ceph_vinop(inode), PTR_ERR_OR_ZERO(dn)); return dn; } -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html