On 18-01-15 08:02 PM, Sage Weil wrote:
On Mon, 15 Jan 2018, Piotr Dałek wrote:
With Mimic, there are a new fields added to pg_stat_t: "state" and
"purged_snaps". My snap trim queue check
(https://github.com/ceph/ceph/pull/19520) adds one more field
("snaptrimq_len") and it is positioned quite unfortunately - AFTER those two,
meaning that I can't add it without adding the other two. Knowing that Mimic
is not out, there are three options:
1 - Backport just
https://github.com/ceph/ceph/pull/19520/commits/dc7781cf17d11cb09067656cb25c0d710ab60d71
that adds snap_trimq_len field to "pg query" command and leave out the rest.
That's not entirely satisfying from my perspective, but it's still a little
step forward.
2 - Fill "state" and "purged snaps" with dummy data in Luminous, but that can
screw up upgrades from Luminous to Mimic.
3 - Reorder fields in master/Mimic and add snaptrimq_len before state and
purged snaps. Probably no impact as Mimic is not out yet.
I think #3 is fine!
I just pushed a PR (https://github.com/ceph/ceph/pull/19965) that does just
that. Once that gets merged I can port snap trim queue check to Luminous.
--
Piotr Dałek
piotr.dalek@xxxxxxxxxxxx
https://www.ovh.com/us/
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
