On Tue, Jan 16, 2018 at 01:09:57AM +0800, kefu chai wrote: > On Tue, Jan 16, 2018 at 1:04 AM, Piotr Dałek <branch@xxxxxxxxxxxxxxxx> wrote: > > On Tue, Jan 16, 2018 at 12:53:22AM +0800, kefu chai wrote: > >> On Mon, Jan 15, 2018 at 11:49 PM, kefu chai <tchaikov@xxxxxxxxx> wrote: > >> > [..] > >> > i am preparing a change to prototype this approach. the downside of it is: > >> > > >> > - we need to include a placeholder structure in buffer.h for > >> > seastar::tempoary_buffer<char>. and cast it to > >> > seastar::tempoary_buffer<char> in buffer.cc . otherwise we need to > >> > include seastar headers in librados. > >> > >> - we cannot store the crc map along with the raw class anymore. this > >> might be a show stopper. > > > > https://github.com/ceph/ceph/pull/18906 > > There, already fixed it. > > Piotr, thanks for point me to this PR. but i am evaluating the pros > and cons of the change, which tries to replace buffer::raw with > seastar::temporary_buffer, and use the latter in buffer::ptr as a > member variable. And I'm pointing out that there's no need to worry about crc map anymore, because it's gone. -- Piotr Dałek branch@xxxxxxxxxxxxxxxx http://blog.predictor.org.pl -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
