On Thu, Nov 2, 2017 at 1:14 AM, David Galloway <dgallowa@xxxxxxxxxx> wrote: > > > On 11/01/2017 12:11 PM, David Galloway wrote: >> On 11/01/2017 01:48 AM, kefu chai wrote: >>> hi Alfredo, >>> >>> i found that jenkins started to comment on PRs when completing a job. >>> for example, see >>> https://github.com/ceph/ceph/pull/18659#issuecomment-340964973. this >>> is a little bit annoying and distracting. but i checked >>> https://github.com/ceph/ceph-build/blob/master/ceph-pull-requests/config/definitions/ceph-pull-requests.yml#L39, >>> we don't specify the success-comment there. i wonder it might be jjb? >>> but i checked the jjb 2.0.0.0b2, it looks sane. see >>> https://github.com/openstack-infra/jenkins-job-builder/blob/04348c2c00657490b4712ae61c6a1bed691a3e3a/jenkins_jobs/modules/triggers.py#L1122. >>> do you have any idea off the head? are we experimenting some new >>> features? >>> >> >> >> I suspect something in GitHub's API changed and the Github Pull Request >> Builder plugin is behind/out of date. >> >> Starting at Nov 01, 2017 2:57:31 AM UTC, ghprb started to indicate it >> was failing to update PR statuses (although I don't think it was) and >> started sending comments. >> >> "Use comments to report results when updating commit status fails" was >> checked in the Jenkins settings. I've unchecked it so hopefully the >> comments will stop for now. >> >> Please let me know if that's not the case. > > Looks like comments stopped. > > We're hitting this/these: > https://github.com/kohsuke/github-api/issues/387 > https://issues.jenkins-ci.org/browse/JENKINS-47601 > > I will update the plugins and restart Jenkins when things are quiet. David, thanks for the quick fix! -- Regards Kefu Chai -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
